Re: [BUG] PCI: fix wrong memory address handling in MSI-X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/17/2010 10:30 PM, Grant Grundler wrote:
On Wed, Jun 16, 2010 at 07:53:37PM -0600, Matthew Wilcox wrote:
On Thu, Jun 17, 2010 at 10:42:44AM +0900, Kenji Kaneshige wrote:
Use resource_size_t for MMIO address instead of unsigned long. Otherwise,
higher 32-bits of MMIO address are cleared unexpectedly in x86-32 PAE.

Signed-off-by: Kenji Kaneshige<kaneshige.kenji@xxxxxxxxxxxxxx>

Acked-by: Matthew Wilcox<willy@xxxxxxxxxxxxxxx>

I guess we never noticed this before because most x86 machines have the
MSI address below 32-bit.

I thought Intel defined x86 MSI to use 0xfee00000 range. So "always"
would be the right term here.

Did you mean "MMIO address"?
(I also believe most x86 have MMIO<  32-bit)

grant

That will generally be true on existing Intel systems, but we certainly shouldn't assume it will be true for all time. I also believe it is different on AMD systems, but I don't remember the details there.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux