On 06/11/2010 02:20 AM, Kenji Kaneshige wrote:
> Current ioremap() code for x86 displays warning message if too high
> address to handle is passed. But this can happen as usual cases. For
> example, if 64-bit BAR is assigned to a PCI device and its device
> driver calls pci_iomap(). So this patch changes the warning messages
> as follows.
>
> - Change printk message from KERN_WARNING to KERN_DEBUG
> - Remove WARN_ON_ONCE()
>
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>
>
> ---
> arch/x86/mm/ioremap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: linux-2.6.34/arch/x86/mm/ioremap.c
> ===================================================================
> --- linux-2.6.34.orig/arch/x86/mm/ioremap.c 2010-06-10 07:28:31.966187993 +0900
> +++ linux-2.6.34/arch/x86/mm/ioremap.c 2010-06-10 07:28:33.146375380 +0900
> @@ -78,9 +78,8 @@
> return NULL;
>
> if (!phys_addr_valid(phys_addr)) {
> - printk(KERN_WARNING "ioremap: invalid physical address %llx\n",
> + printk(KERN_DEBUG "ioremap: can't map physical address %llx\n",
> (unsigned long long)phys_addr);
> - WARN_ON_ONCE(1);
> return NULL;
> }
>
Fair to change the message, but the priority level really seems way
insufficient. I can see dropping the WARN_ON_ONCE() though.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
