pci_read/write_vpd() can fail due to a timeout. Usually the command times out
because of FW issues (incorrect vpd length, etc.) on the PCI card. Currently,
the timeout occurs silently.
Output a message to the user indicating that they should check with their
vendor for new FW.
Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 2f646fe..5ea8aaf 100644
--- a/drivers/pci/access.c
+++ b/drivers/pci/access.c
@@ -220,8 +220,13 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev)
return 0;
}
- if (time_after(jiffies, timeout))
+ if (time_after(jiffies, timeout)) {
+ dev_printk(KERN_DEBUG, &dev->dev,
+ "vpd read failed. This is likely a FW bug "
+ "on this device. Contact the card vendor "
+ "a FW update.");
return -ETIMEDOUT;
+ }
if (fatal_signal_pending(current))
return -EINTR;
if (!cond_resched())
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
