On Thu, 08 Apr 2010 17:07:55 -0700 Yinghai <yinghai.lu@xxxxxxxxxx> wrote: > On 04/08/2010 04:24 PM, Chris Wright wrote: > > * Yinghai (yinghai.lu@xxxxxxxxxx) wrote: > >> --- linux-2.6.orig/drivers/pci/dmar.c > >> +++ linux-2.6/drivers/pci/dmar.c > >> @@ -534,6 +534,8 @@ dmar_find_matched_drhd_unit(struct pci_d > >> struct dmar_drhd_unit *dmaru = NULL; > >> struct acpi_dmar_hardware_unit *drhd; > >> > >> + dev = pci_physfn(dev); > >> + > > > > Yeah, we typically don't have enough VF's to wrap bus numbers, or we're > > under a catchall IOMMU. In the catchall case both vf->bus and vf->pf->bus > > will have the same domain (segment) regardless of whether we have large > > VF count or big offset/stride. So, I suppose this could be done inside > > of dmar_pci_device_match(). > > > > Otherwise, I think you'd want to add the same thing to > > dmar_find_matched_atsr_unit() since it's the same device scopes there. > > please check > > Subject: [PATCH] pci/dmar/sriov: use physfn to search drhd for VF > > When virtfn is used, we should use physfn to find correct drhd > > -v2: add pci_physfn() Suggested by Roland Dreier <rdreier@xxxxxxxxx> > do can remove ifdef in dmar.c > -v3: Chris pointed out we need that for dma_find_matched_atsr_unit too > also change dmar_pci_device_match() static > > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> > Acked-by: Roland Dreier <rdreier@xxxxxxxxx> This one looks good: Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
