(2010/04/09 14:11), Kenji Kaneshige wrote: > I mis-understood that those four bits were all the status bits in the Root > Error Status Register defined in PCIe spec. So I thought it was natural to > have PCI_ERR_STATUS_MASK and use it to check all the status bits. This was > the reason of my suggestion. > > But now I noticed that it is not a set of all the status bits, but a set > of bits to which aer interrupt hander is interested. It would be hard for > people to understand what PCI_ERR_ROOT_STATUS_MASK stands for. As a result, > I think your change is good. Thanks. > By the way, do we need to check PCI_ERR_ROOT_MULTI_UNCOR_RCV and > PCI_ERR_ROOT_MULTI_COR_RCV here? Good point. We should process error no matter there are multi error or not. So what we have to check here is only 2 bits: PCI_ERR_ROOT_UNCOR_RCV and PCI_ERR_ROOT_COR_RCV. I'll fix it. Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
