Re: [PATCH 18/22] aerdrv: trivial cleanup for aerdrv_core.c

[Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>]

Reviewed-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>

Hidetoshi Seto wrote:
> Style cleanup for pci_{en,dis}able_pcie_error_reporting().
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>
> ---
>  drivers/pci/pcie/aer/aerdrv_core.c |   21 ++++++++++-----------
>  1 files changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
> index 4bd4b4f..09e61ca 100644
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -46,13 +46,12 @@ int pci_enable_pcie_error_reporting(struct pci_dev *dev)
>  	if (!pos)
>  		return -EIO;
>  
> -	pci_read_config_word(dev, pos+PCI_EXP_DEVCTL, &reg16);
> -	reg16 = reg16 |
> -		PCI_EXP_DEVCTL_CERE |
> +	pci_read_config_word(dev, pos + PCI_EXP_DEVCTL, &reg16);
> +	reg16 |= (PCI_EXP_DEVCTL_CERE |
>  		PCI_EXP_DEVCTL_NFERE |
>  		PCI_EXP_DEVCTL_FERE |
> -		PCI_EXP_DEVCTL_URRE;
> -	pci_write_config_word(dev, pos+PCI_EXP_DEVCTL, reg16);
> +		PCI_EXP_DEVCTL_URRE);
> +	pci_write_config_word(dev, pos + PCI_EXP_DEVCTL, reg16);
>  
>  	return 0;
>  }
> @@ -70,12 +69,12 @@ int pci_disable_pcie_error_reporting(struct pci_dev *dev)
>  	if (!pos)
>  		return -EIO;
>  
> -	pci_read_config_word(dev, pos+PCI_EXP_DEVCTL, &reg16);
> -	reg16 = reg16 & ~(PCI_EXP_DEVCTL_CERE |
> -			PCI_EXP_DEVCTL_NFERE |
> -			PCI_EXP_DEVCTL_FERE |
> -			PCI_EXP_DEVCTL_URRE);
> -	pci_write_config_word(dev, pos+PCI_EXP_DEVCTL, reg16);
> +	pci_read_config_word(dev, pos + PCI_EXP_DEVCTL, &reg16);
> +	reg16 &= ~(PCI_EXP_DEVCTL_CERE |
> +		PCI_EXP_DEVCTL_NFERE |
> +		PCI_EXP_DEVCTL_FERE |
> +		PCI_EXP_DEVCTL_URRE);
> +	pci_write_config_word(dev, pos + PCI_EXP_DEVCTL, reg16);
>  
>  	return 0;
>  }


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html