On Thursday 01 April 2010, Alex Deucher wrote: > On Thu, Apr 1, 2010 at 2:36 AM, Clemens Ladisch <clemens@xxxxxxxxxx> wrote: > > Alex Deucher wrote: > >> On Wed, Mar 31, 2010 at 9:13 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > >>> On Tuesday 30 March 2010, Rafael J. Wysocki wrote: > >>>> > PCI quirk: RS780/RS880: work around missing MSI initialization > >>>> > >>>> This one (commit a5ee4eb7541) broke OpenGL acceleration on my new test box > >>>> which happens to have a RS780. > > > > So it's better to disable MSI unconditionally. > > > > Rafael, can you check if MSI works for the HDMI audio device? > > (I'd guess it doesn't.) > > > >> I also have the attached patch queued in via Dave's tree to disable > >> MSI on all IGP chips for the time being. > > > > This disables MSI only for the graphics device. I'd prefer to have > > the quirk on its bridge so that MSI gets disabled for the HDMI audio > > device too, to avoid having to duplicate this quirk in the snd-hda-intel > > driver. > > > > ========== > > > > PCI quirk: RS780/RS880: disable MSI completely > > > > The missing initialization of the nb_cntl.strap_msi_enable does not seem > > to be the only problem that prevents MSI, so that quirk is not > > sufficient to enable MSI on all machines. To be safe, unconditionally > > disable MSI for the internal graphics and HDMI audio on these chipsets. > > > > Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx> > > Works fine here. > > Tested-by: Alex Deucher <alexdeucher@xxxxxxxxx> Unfortunately it doesn't work for me without the if ((rdev->family >= CHIP_RV380) && (!(rdev->flags & RADEON_IS_IGP))) radeon quirk. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html