On Thursday 01 April 2010 12:15:49 pm Yinghai Lu wrote:
> On Wed, Mar 31, 2010 at 3:56 PM, Ira W. Snyder <iws@xxxxxxxxxxxxxxxx> wrote:
> > On Wed, Mar 31, 2010 at 03:32:09PM -0600, Bjorn Helgaas wrote:
> >> On Wednesday 31 March 2010 12:45:14 pm Ira W. Snyder wrote:
> >> > On Wed, Mar 31, 2010 at 12:13:46PM -0600, Bjorn Helgaas wrote:
> >> > > On Wednesday 31 March 2010 10:38:42 am Ira W. Snyder wrote:
> >>
> >> > > The CNB20LE might also be used in systems that *do* have ACPI, and in
> >> > > that case, I think we should use ACPI rather than read the info out of
> >> > > the hardware. I expect that's what Windows will do, and Linux should
> >> > > do the same as Windows when it's practical. Also, that's what the BIOS
> >> > > writers expect the OS to do, and _CRS is the logical place for them to
> >> > > put platform-specific workarounds.
> >> >
> >> > Is there any way to detect if we do have ACPI and shouldn't run this
> >> > quirk? How?
> >>
> >> Probably check "acpi_disabled".
> >>
> >
> > Ok, I'll give this a shot.
>
> do not need that. bus_numa.c already did that check for you.
>
> void x86_pci_root_bus_res_quirks(struct pci_bus *b)
> {
> int i;
> int j;
> struct pci_root_info *info;
>
> /* don't go for it if _CRS is used already */
> if (b->resource[0] != &ioport_resource ||
> b->resource[1] != &iomem_resource)
> return;
Uh, ok. I think that's a pretty non-obvious connection, but I suppose
it does work. I'd rather write code that says what you mean, rather
than relying on a side-effect of something else.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
