On Thu, Apr 1, 2010 at 1:24 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > > On Thu, 1 Apr 2010, Alex Deucher wrote: >> >> Clemems' "PCI quirk: RS780/RS880: disable MSI completely" patch is the >> right approach I think. Note that it's only devices hung off the int >> gfx pci to pci bridge that have broken MSI (gfx and audio). MSI works >> fine on the PCIE slots. I have a similar patch for rs400 chips on bug >> 15626: >> https://bugzilla.kernel.org/show_bug.cgi?id=15626 > > Hmm. Does 'pci_msi_enable' only cover regular PCI devices? Or will that > pci_no_msi() quirk disable MSI for PCIE too? I think it will trigger for > PCIE drivers too. > > Put another way: it sounds like the quirk now disables MSI for all > devices. Maybe there would some more targeted mode? > What I meant to say was MSI works fine on bridges other than the bridge the internal gfx lives on. quirk_disable_msi() just disables MSI on the devices on that particular bridge as far as I understand it, but I'm by no means an expert on the PCI code. E.g., on my RS780 board, MSIs are only problematic on the integrated gfx chip. MSIs work fine on PCI/PCIE add-on cards and the integrated Ethernet. Alex > Linus > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
