Re: [PATCH 1/3] PCI: don't say we claimed a resource if we failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 22 Mar 2010 16:34:05 -0600
Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:

> 
> pci_claim_resource() can fail, so pay attention and only claim success
> when it actually succeeded.  If pci_claim_resource() fails, it prints a
> useful diagnostic.
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> ---
> 
>  drivers/pci/quirks.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 81d19d5..806b5c2 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -368,8 +368,9 @@ static void __devinit quirk_io_region(struct pci_dev *dev, unsigned region,
>  		bus_region.end = res->end;
>  		pcibios_bus_to_resource(dev, res, &bus_region);
>  
> -		pci_claim_resource(dev, nr);
> -		dev_info(&dev->dev, "quirk: %pR claimed by %s\n", res, name);
> +		if (pci_claim_resource(dev, nr) == 0)
> +			dev_info(&dev->dev, "quirk: %pR claimed by %s\n",
> +				 res, name);
>  	}
>  }	
>  
> 
> 

Applied these to my for-linus branch to help with any other issues we
run into.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux