On Tue, 9 Mar 2010 22:26:40 -0500 Dean Nelson <dnelson@xxxxxxxxxx> wrote: > For the PCI_X_STATUS register, pcix_get_max_mmrbc() is returning an incorrect > value, which is based on: > > (stat & PCI_X_STATUS_MAX_READ) >> 12 > > Valid return values are 512, 1024, 2048, 4096, which correspond to a 'stat' > (masked and right shifted by 21) of 0, 1, 2, 3, respectively. > > A right shift by 11 would generate the correct return value when 'stat' (masked > and right shifted by 21) has a value of 1 or 2. But for a value of 0 or 3 it's > not possible to generate the correct return value by only right shifting. > > Fix is based on pcix_get_mmrbc()'s similar dealings with the PCI_X_CMD register. > > Signed-off-by: Dean Nelson <dnelson@xxxxxxxxxx> > > --- > > drivers/pci/pci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 5b548ae..1decd4f 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -2571,7 +2571,7 @@ int pcix_get_max_mmrbc(struct pci_dev *dev) > if (err) > return -EINVAL; > > - return (stat & PCI_X_STATUS_MAX_READ) >> 12; > + return 512 << ((stat & PCI_X_STATUS_MAX_READ) >> 21); > } > EXPORT_SYMBOL(pcix_get_max_mmrbc); Applied this series, thanks Dean. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
