[PATCH 2/2] pci/dmar: Tone down warnings about invalid BIOS DMAR tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We now know how to deal with these tables so that they are harmless.
Don't taint the kernel and don't say the BIOS is 'broken' as this
makes users think of hardware damage.

Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
We usually insist that a reported bug is reproducible without a tainted
kernel.  In this case, the warning taint is unavoidable and looking for
the warning messages is a waste of time for me as a distribution
maintainer for bug submitters.

Ben.

 drivers/pci/dmar.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index d925439..7bd03a6 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -587,12 +587,12 @@ static void warn_invalid_dmar(u64 addr, const char *message)
 	static int bios_warned;
 
 	if (!bios_warned) {
-		WARN(1, "Your BIOS is broken; DMAR reported at address %llx%s!\n"
-		     "BIOS vendor: %s; Ver: %s; Product Version: %s\n",
-		     addr, message,
-		     dmi_get_system_info(DMI_BIOS_VENDOR),
-		     dmi_get_system_info(DMI_BIOS_VERSION),
-		     dmi_get_system_info(DMI_PRODUCT_VERSION));
+		pr_warning(PREFIX "BIOS bug: DMAR reported at address %llx%s!\n"
+			   PREFIX "BIOS vendor: %s; Ver: %s; Product Version: %s\n",
+			   addr, message,
+			   dmi_get_system_info(DMI_BIOS_VENDOR),
+			   dmi_get_system_info(DMI_BIOS_VERSION),
+			   dmi_get_system_info(DMI_PRODUCT_VERSION));
 		bios_warned = 1;
 	}
 }
-- 
1.7.0


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux