Re: [PATCH] PCI: clearing wakeup flags not needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 08 March 2010, Alan Stern wrote:
> This patch (as1353) removes a couple of unnecessary assignments from
> the PCI core.  The should_wakeup flag is naturally initialized to 0;
> there's no need to clear it.
> 
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Acked-by: Rafael J. Wysocki <rjw@xxxxxxx>

> ---
> 
> Index: usb-2.6/drivers/pci/pci.c
> ===================================================================
> --- usb-2.6.orig/drivers/pci/pci.c
> +++ usb-2.6/drivers/pci/pci.c
> @@ -1450,7 +1450,6 @@ void pci_pm_init(struct pci_dev *dev)
>  		 * let the user space enable it to wake up the system as needed.
>  		 */
>  		device_set_wakeup_capable(&dev->dev, true);
> -		device_set_wakeup_enable(&dev->dev, false);
>  		/* Disable the PME# generation functionality */
>  		pci_pme_active(dev, false);
>  	} else {
> @@ -1474,7 +1473,6 @@ void platform_pci_wakeup_init(struct pci
>  		return;
>  
>  	device_set_wakeup_capable(&dev->dev, true);
> -	device_set_wakeup_enable(&dev->dev, false);
>  	platform_pci_sleep_wake(dev, false);
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux