On Sun, Feb 28, 2010 at 1:30 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote: > This addresses <http://bugzilla.kernel.org/show_bug.cgi?id=15021>. > > DRM drivers may fail to probe their devices when the associated AGP > GART does not yet have a driver, so we reprobe unbound VGA devices > when a GART device is added. > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > --- > This is intended to address the dependency problem highlighted in the > above bug report. That specific bug can be fixed by adding a module > dependency from i915 to intel_agp, but in general there is no fixed > relationship betweem DRM and GART drivers. > > There is a narrow race between the check for a current driver binding > and the call to device_reprobe(). This could be closed by adding a > variant on device_attach() and device_reprobe() that is a no-op for > bound devices. > This isn't useful, generally there is no AGP binding, and most drivers if they can't find an AGP backend will still run fine without it. i.e. radeon, mga etc. Intel is a special case and I think we've already merged an explicit depend. Just build agp drivers into the kernel, I'm tempted to make them all non-modular. Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
