On Fri, 2010-02-26 at 12:40 -0800, Matt Carlson wrote: > This patch adds the pci_vpd_find_info_keyword() helper function to > find information field keywords within read-only and read-write large > resource data type sections. [...] > +/** > + * pci_vpd_find_info_keyword - Locates an information field keyword in the VPD > + * @buf: Pointer to buffered vpd data > + * @off: The offset into the buffer at which to begin the search > + * @len: The length of the buffer area, relative to off, in which to search > + * @kw: The keyword to search for > + * > + * Returns the index where the information field keyword was found or > + * -ENOENT otherwise. > + */ > +int pci_vpd_find_info_keyword(u8 *buf, unsigned int off, > + unsigned int len, char *kw); [...] The kw pointer should be const-qualified. The buf pointers could also be const-qualified though this is less important. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
