On Sat, Feb 20, 2010 at 4:44 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Sat, Feb 20, 2010 at 12:50:53PM +0000, Alan Jenkins wrote: > >> 1. checking PCI config space, to see whether the device is really absent >> before we mark it as unplugged. >> 2. a generic mechanism which would replace the current eeepc-specific code. > > The generic mechanism will become necessary with .34 anyway, as soon as > the PCI runtime power management code lands. It'll be taking the > notification handlers for these devices. > > I think we effectively need to move some of the acpiphp code and make it > generic. These shouldn't be exposed as hotplug slots, but if we receive > a rescan notification and the device is no longer there then it's pretty > obvious that we need to remove it... > > On the other hand, your patch looks fine for the immediate issue. > > -- > Matthew Garrett | mjg59@xxxxxxxxxxxxx > Alan, could you re-send the patch with a formated changelog ? (and you can add my Acked-By) Thanks, -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
