On 02/09/2010 11:56 AM, Pekka Enberg wrote: > On Tue, Feb 9, 2010 at 9:49 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: >> On Tue, 09 Feb 2010 11:32:39 -0800 >> Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >> >>> prepare to use it in early_irq_init() >>> >>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> >>> --- >>> init/main.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/init/main.c b/init/main.c >>> index 4cb47a1..8451878 100644 >>> --- a/init/main.c >>> +++ b/init/main.c >>> @@ -584,6 +584,7 @@ asmlinkage void __init start_kernel(void) >>> local_irq_disable(); >>> } >>> rcu_init(); >>> + radix_tree_init(); >>> /* init some links before init_ISA_irqs() */ >>> early_irq_init(); >>> init_IRQ(); >>> @@ -657,7 +658,6 @@ asmlinkage void __init start_kernel(void) >>> proc_caches_init(); >>> buffer_init(); >>> key_init(); >>> - radix_tree_init(); >>> security_init(); >>> vfs_caches_init(totalram_pages); >>> signals_init(); >> >> Probably OK. Note that radix_tree_init() uses slab, and it is now being >> called before the kernel has run kmem_cache_init_late(). So please >> ensure that this code was tested with CONFIG_SLAB=y. > > That should be fine but yeah, definitely needs to be tested. tested with x86 bit with CONFIG_SLAB=y, and it works. YH -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html