Re: [PATCH 04/35] x86/pci: amd one chain system to use pci read out res

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 09 Feb 2010 11:32:15 -0800
Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> --- a/arch/x86/pci/amd_bus.c
> +++ b/arch/x86/pci/amd_bus.c
> @@ -87,11 +87,12 @@ static int __init early_fill_mp_bus_info(void)
>  	struct range range[RANGE_NUM];
>  	u64 val;
>  	u32 address;
> +	int found;

It'd be clearer to give this the `bool' type.  After all, it's a bool.

>  
>  	if (!early_pci_allowed())
>  		return -1;
>  
> -	found_all_numa_early = 0;
> +	found = 0;
>  	for (i = 0; i < ARRAY_SIZE(pci_probes); i++) {
>  		u32 id;
>  		u16 device;
> @@ -105,12 +106,12 @@ static int __init early_fill_mp_bus_info(void)
>  		device = (id>>16) & 0xffff;
>  		if (pci_probes[i].vendor == vendor &&
>  		    pci_probes[i].device == device) {
> -			found_all_numa_early = 1;
> +			found = 1;
>  			break;
>  		}
>  	}
>  
> -	if (!found_all_numa_early)
> +	if (!found)
>  		return 0;
>  
>  	pci_root_num = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux