Re: [PATCH 2/2] PCI: Add checking to register reads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 15 Jan 2010 16:32:58 -0700
Myron Stowe <myron.stowe@xxxxxx> wrote:

> Alex Williamson pointed out that the IOH_VTBAR read, as currently
> implemented, could silently fail and, if this occurred, 'dword' would
> be -1.  Under these conditions the check of whether or not the VTBAR
> was enabled - if (dword & 0x1 && ... - would be incorrectly
> interpreted as true.  Thus began the slippery slope of adding checks
> to register reads.
> 
> Signed-off-by: Myron Stowe <myron.stowe@xxxxxx>

Applied both of these, thanks Myron.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux