On Fri, 15 Jan 2010 10:47:54 -0700 Myron Stowe <myron.stowe@xxxxxx> wrote: > I do have to ask however - what tree are you using? I noticed that > 'add_range()' and 'subtract_range()' are static routines related to > mtrr code. I rebased my git tree to tip and applied your latest > patch and got: > arch/x86/pci/intel_bus.c: In function ‘pci_root_bus_res’: > arch/x86/pci/intel_bus.c:56: error: array type has incomplete > element type arch/x86/pci/intel_bus.c:87: error: implicit declaration > of function ‘add_range’ arch/x86/pci/intel_bus.c:95: error: implicit > declaration of function ‘subtract_range’ > arch/x86/pci/intel_bus.c:101: error: implicit declaration of function > ‘cap_resource’ arch/x86/pci/intel_bus.c:56: warning: unused variable > ‘range’ make[1]: *** [arch/x86/pci/intel_bus.o] Error 1 make: *** > [arch/x86/pci] Error 2 I think Yinghai is basing his work on top of a growing set of patches I haven't applied yet. I'm going through them today with the intent of applying at least some of them though. Your original patch looks pretty good, I'll apply it to my linux-next branch. Bjorn's idea to clean up the extended config space check seems like a good one though too, but refactoring like that and what you and Yinghai are discussing can go on top since it's not directly related to this functionality. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
