On Wednesday 13 January 2010 06:56:40 Andrew Morton wrote:
>
> Your email client is performing wordwrapping on the patches.
Sorry for this, I changed the word wrap settings of my client
>
> All the other ioremap() calls are checked for failure, so this one
> should also be checked, no?
Yes, it needs to be checked. thanks for adding the additional check.
>
> --- a/drivers/pci/hotplug/ibmphp_ebda.c~ibmphp-read-the-length-of-ebda-and-map-entire-ebda-region-fix
> +++ a/drivers/pci/hotplug/ibmphp_ebda.c
> @@ -261,6 +261,8 @@ int __init ibmphp_access_ebda (void)
> debug ("returned ebda segment: %x\n", ebda_seg);
>
> io_mem = ioremap(ebda_seg<<4, 1);
> + if (!io_mem)
> + return -ENOMEM;
> ebda_sz = readb(io_mem);
> iounmap(io_mem);
> debug("ebda size: %d(KiB)\n", ebda_sz);
> _
>
>
> A kernel oops is somewhat serious. Would I be correct in assuming that
> this fix is needed in 2.6.32.x and perhaps earlier kernels?
Yes, I just checked with 2.6.30 kernel and the issue exists over there too. So it applies to all older kernels.
Thanks,
Chandru
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
