Good catch. Reviewed-by: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> Jiri Slaby wrote: > Stanse found a cut&pasted memory leak in pciehp_queue_pushbutton_work > and shpchp_queue_pushbutton_work. info is not freed/assigned on all > paths. Fix that. > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx > --- > drivers/pci/hotplug/pciehp_ctrl.c | 1 + > drivers/pci/hotplug/shpchp_ctrl.c | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c > index d6ac1b2..9a7f247 100644 > --- a/drivers/pci/hotplug/pciehp_ctrl.c > +++ b/drivers/pci/hotplug/pciehp_ctrl.c > @@ -341,6 +341,7 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) > p_slot->state = POWERON_STATE; > break; > default: > + kfree(info); > goto out; > } > queue_work(pciehp_wq, &info->work); > diff --git a/drivers/pci/hotplug/shpchp_ctrl.c b/drivers/pci/hotplug/shpchp_ctrl.c > index b8ab279..86f6276 100644 > --- a/drivers/pci/hotplug/shpchp_ctrl.c > +++ b/drivers/pci/hotplug/shpchp_ctrl.c > @@ -462,6 +462,7 @@ void shpchp_queue_pushbutton_work(struct work_struct *work) > p_slot->state = POWERON_STATE; > break; > default: > + kfree(info); > goto out; > } > queue_work(shpchp_wq, &info->work); -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
