On Sat, 2 Jan 2010 22:57:24 +0100 "Rafael J. Wysocki" <rjw@xxxxxxx> wrote: > From: Rafael J. Wysocki <rjw@xxxxxxx> > > Currently, drivers/pci/quirks.c is built unconditionally, but if > CONFIG_PCI_QUIRKS is unset, the only things actually built in this > file are definitions of global variables and empty functions (due to > the #ifdef CONFIG_PCI_QUIRKS embracing all of the code inside the > file). This is not particularly nice and if someone overlooks > the #ifdef CONFIG_PCI_QUIRKS, build errors are introduced. > > To clean that up, move the definitions of the global variables in > quirks.c that are always built to pci.c, move the definitions of > the empty functions (compiled when CONFIG_PCI_QUIRKS is unset) to > headers (additionally make these functions static inline) and modify > drivers/pci/Makefile so that quirks.c is only built if > CONFIG_PCI_QUIRKS is set. > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx> > --- > > I thought it might be useful to do something like this. > > Please let me know what you think. Thanks Rafael, I actually had a fix for this already from Dexuan, but I guess Linus applied yours instead. Thanks for the fix. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
