On Fri, 18 Dec 2009 16:49:48 +0800 Dexuan Cui wrote:
> When CONFIG_PCI_QUIRKS=n, the kernel build fails:
> > drivers/built-in.o: In function `pci_dev_reset':
> > pci.c:(.text+0xdb0b): undefined reference to `pci_dev_reset_methods'
> > pci.c:(.text+0xdb2b): undefined reference to `pci_dev_reset_methods'
> > pci.c:(.text+0xdb85): undefined reference to `pci_dev_reset_methods'
>
> We should add a dummy pci_dev_reset_methods[] in this case.
OK, that works. I admit that I would have just made a stub for
pci_dev_specific_reset() in pci.c instead, or just put the
data struct and for-loop inside #ifdef CONFIG_PCI_QUIRKS/#endif.
Thanks.
> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>
> ---
> drivers/pci/quirks.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 8726698..15de139 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2692,6 +2692,10 @@ struct pci_dev_reset_methods pci_dev_reset_methods[] = {
> { 0 }
> };
> #else
> +struct pci_dev_reset_methods pci_dev_reset_methods[] = {
> + { 0 }
> +};
> +
> void pci_fixup_device(enum pci_fixup_pass pass, struct pci_dev *dev) {}
> #endif
> EXPORT_SYMBOL(pci_fixup_device);
> --
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
