* Alex Chiang <achiang@xxxxxx>: > * Rakib Mullick <rakib.mullick@xxxxxxxxx>: > > On 12/5/09, Alex Chiang <achiang@xxxxxx> wrote: > > > * Rakib Mullick <rakib.mullick@xxxxxxxxx>: > > > > > > This is from Linus's latest tree: > > > > > > 974 > > > 975 if (slot->flags & SLOT_ENABLED) > > > 976 goto err_exit; > > > > I'm talking about this line. From here we can hit 'goto err_exit' without > > using pci_get_slot. > > Right, so what's the problem? If the slot is not enabled, we goto > err_exit and return, never touching dev. Whoops, of course I meant if the slot is already enabled, then we return early. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html