On Thu, 03 Dec 2009 10:28:20 -0700 Andrew Patterson <andrew.patterson@xxxxxx> wrote: > PCI: unconditionally clear AER uncorr status register during cleanup > > The current implementation of pci_cleanup_aer_uncorrect_error_status > only clears either fatal or non-fatal error status bits depending > on the state of the I/O channel. This implementation will then often > leave some bits set after PCI error recovery completes. The > uncleared bit settings will then be falsely reported the next time an > AER interrupt is generated for that hierarchy. An easy way to > illustrate this issue is to use the aer-inject module to > simultaneously inject both an uncorrectable non-fatal and > uncorrectable fatal error. One of the errors will not be cleared. > > This patch resolves this issue by unconditionally clearing all bits in > the AER uncorrectable status register. All settings and corrective > action strategies are saved and determined before > pci_cleanup_aer_uncorrect_error_status is called, so this change > should not affect errory handling functionality. > > Signed-off-by: Andrew Patterson <andrew.patterson@xxxxxx> Applied these two, thanks Andrew. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
