Jeff Garzik <jeff@xxxxxxxxxx> writes: > Think about this from an engineering perspective. This patch is > driven not by any real technical need, but more by marketing and > trademark folks. Uh, I'm not sure about this. It would be much better if the kernel was consistent in naming the PCI versions, not like today: PCIe, PCIE, PCI-E, PCI-express, PCI-X, PCIX etc, including the user-visible cases (but obviously not the EDD and similar things). But I think it should be handler by individual maintainers. > Finally, split your patch up. I would suggest starting with 100% > comment changes that are guaranteed with mathematical certainty to not > change the compiler-generated code at all. That will make the > remaining changes much easier to review, if they are in separate > patches from the comment-only changes. Absolutely. Perhaps that older PCI patch should be done first, it was a good one IIRC. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
