Re: [PATCH] pci: print out DMA mask info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rolf Eike Beer wrote:
> Yinghai Lu wrote:
> 
>> Index: linux-2.6/drivers/pci/pci.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/pci/pci.c
>> +++ linux-2.6/drivers/pci/pci.c
>> @@ -2101,6 +2101,8 @@ pci_set_dma_mask(struct pci_dev *dev, u6
>>  		return -EIO;
>>
>>  	dev->dma_mask = mask;
>> +	dev_printk(KERN_DEBUG, &dev->dev, "using %dbit DMA mask\n",
>> +		 fls64(mask));
>>
>>  	return 0;
>>  }
>> @@ -2112,6 +2114,8 @@ pci_set_consistent_dma_mask(struct pci_d
>>  		return -EIO;
>>
>>  	dev->dev.coherent_dma_mask = mask;
>> +	dev_printk(KERN_DEBUG, &dev->dev, "using %dbit consistent DMA mask\n",
>> +		 fls64(mask));
>>
>>  	return 0;
>>  }
> 
> This could use dev_dbg, no?

if PCI_DEBUG is not selected, dev_dbg will not print out anything even you have "debug" in boot command line.

think should have extra debug lever like

KERN_SPEW for DEBUG + 1

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux