On Mon, 16 Nov 2009 14:21:13 -0700 Alex Chiang <achiang@xxxxxx> wrote: > commit db635adc turned -DDEBUG for x86/pci on when CONFIG_PCI_DEBUG > is set. In general, I agree with that change. > > However, it exposes a bunch of very low level PCI debugging in the > early x86 path, such as: > > 0 reading 2 from a: ffff > 1 reading 2 from a: ffff > 2 reading 2 from a: ffff > 3 reading 2 from a: 300 > 3 reading 2 from 0: 1002 > 3 reading 2 from 2: 515e > > These statements add a lot of noise to the boot and aren't likely to > be necessary even when handling random upstream bug reports. > > [In contrast, statements such as these: > > pci 0000:02:04.0: found [14e4:164a] class 000200 header type > 00 pci 0000:02:04.0: reg 10: [mem 0xf8000000-0xf9ffffff 64bit] > pci 0000:02:04.0: reg 30: [mem 0x00000000-0x0001ffff pref] > > are indeed useful when remote debugging users' machines] > > Remove the noisy printks and save electrons everywhere. Applied, thanks. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
