On Friday 13 November 2009, Breno Leitao wrote: > Actually pci_restore_state() is returning 0 if the restore process > fails, instead of a error value. > > If it fails, I believe that it should return -EPERM, once that > it is an invalid operation and probably pci_save_state() wasn't > called. I believe this patch will break a number of things. Does it actually fix any problem you have observed? Rafael > Signed-off-by: Breno Leitao <leitao@xxxxxxxxxxxxxxxxxx> > --- > drivers/pci/pci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 4e4c295..b677ca3 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -857,7 +857,7 @@ pci_restore_state(struct pci_dev *dev) > u32 val; > > if (!dev->state_saved) > - return 0; > + return -EPERM; > > /* PCI Express register must be restored first */ > pci_restore_pcie_state(dev); > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
