Matthew Wilcox wrote:
> On Fri, Nov 06, 2009 at 05:24:55PM +0800, Dexuan Cui wrote:
>> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
>> index d92d195..02247ac 100644
>> --- a/drivers/pci/pci.h
>> +++ b/drivers/pci/pci.h
>> @@ -311,4 +311,12 @@ static inline int pci_resource_alignment(struct
>> pci_dev *dev, return resource_alignment(res);
>> }
>>
>> +struct pci_dev_reset_methods {
>> + u16 vendor;
>> + u16 device;
>> + int (*reset)(struct pci_dev *dev, int probe);
>> +};
>> +
>> +extern struct pci_dev_reset_methods pci_dev_reset_methods[]; +
>> #endif /* DRIVERS_PCI_H */
>
> Why do it this way instead of having a ->reset method in struct
> pci_driver?
Sorry for the late reply as I was on an accidental leave.
Hi Matthew,
Currently pci_reset_function() is mainly used by kvm_vm_ioctl_assign_device() and kvm_free_assigned_device(). In the case of KVM VT-d, in host the driver of the device assigned to HVM guest is not the "genuine" one -- it should always be the dummy driver "pci-stub" or NULL, because the "genuine" driver in HVM guest would control the device and in host we should not load an actual driver for the device.
So adding a 'reset' field into struct pci_driver doesn't sound like a good idea to me.
And the existing pci_dev_reset() has been there for quite a while, so I think adding pci_dev_specific_reset() into pci_dev_reset() should be good.
Thanks,
-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
