Alex Chiang wrote:
Hello Kenji-san,
I'm hitting a BUG_ON() in pcie_update_aspm_capable(), introduced
in 07d92760d2ee542fe932f4e8b5807dd98481d1fd during a PCI logical
hotplug operation.
I don't understand the intent of the BUG_ON(root->parent). It
doesn't seem like it's exactly necessary to me, but I admit that
I don't understand the ASPM design very well.
The pcie_update_aspm_capable() assumes that the pointer to struct
pcie_link_state for root port link is passed as a input parameter.
This BUG_ON() checks it (If the 'parent' field in pcie_link_state
is not NULL, it is not for root port link).
I think you're trying to remove PCIe root port using logical hotplug
operation this time. Current my thinking is that there are some lack
of consideration for root port removal in pcie_update_aspm_capable().
I'll investigate it more and report the result as soon as possible.
Thanks,
Kenji Kaneshige
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
