On Sun, 06 Sep 2009 21:48:35 -0700 ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote: > > There is a very old quirk for the intel E7502 E7320 and E7525 memory > controller hubs that disables usage of msi interrupts on pcie hotplug > bridges of those devices, and disables changing the affinity of irqs. > > Today all we have to do to disable msi on a specific device is to set > dev->no_msi, which is much more straightforward than the previous > logic. > > The re-running of this fixup after pci hotplug happens below these > devices is totally bogus. All of the state we change is pure software > state and we don't change the hardware at all. Which means hotplug on > the lower devices doesn't have a chance to change this state. So we > can safely remove the special case from the pciehp driver and the pcie > portdriver. > > I suspect the special case was someone's expermental debug code that > slipped in. Certainly it isn't mentioned in commit > 6fb8880a61510295aece04a542767161f624dffe aka BKrev: > 41966101LJ_ogfOU0m2aE6teZfQnuQ where the code first appears. > > Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> Applied to linux-next, thanks. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
