On Thursday 20 August 2009 09:38:07 pm Hidetoshi Seto wrote: > Some fixes related to multiple error reporting included. > Based on pci/linux-next, but can be applied to linus's master too. > (RFC: Is it better to push some for .31?) Since you're doing a lot of cleanup in aerdrv_errprint.c anyway, the format of the messages it prints is pretty strange compared to typical Linux messages. Here's a sample: +------ PCI-Express Device Error ------+ Error Severity : Corrected PCIE Bus Error type : Physical Layer Receiver Error : First Receiver ID : 0f00 VendorID=103ch, DeviceID=403bh, Bus=0fh, Device=00h, Function=00h I'd like this a lot better if it used dev_printk and other Linux conventions, e.g., "pci 0000:0f:00.0" instead of "Bus=0fh, Device=00h, Function=00h" and "device[103c:403b]" instead of "VendorID=103ch, DeviceID=403bh". Also, it currently calls printk many times, so the output is often interspersed with other messages, and there's no nice way to put it back together or even tell where the end is. There's no loop, so there is a clear maximum output size; maybe everything could be put into a buffer and printed with a single dev_printk to make it atomic. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
