Re: [PATCH 8/8] pci/msi: Style cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 06, 2009 at 11:36:52AM +0900, Hidetoshi Seto wrote:
> Cleanups (nearly based on checkpatch).
> 
> Before: total: 11 errors, 2 warnings, 0 checks, 842 lines checked
> After:  total:  0 errors, 0 warnings, 0 checks, 842 lines checked
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>

> @@ -601,7 +600,8 @@ static int pci_msi_check_device(struct pci_dev* dev, int nvec, int type)
>  	if (nvec < 1)
>  		return -ERANGE;
>  
> -	/* Any bridge which does NOT route MSI transactions from it's
> +	/*
> +	 * Any bridge which does NOT route MSI transactions from it's
>  	 * secondary bus to it's primary bus must set NO_MSI flag on
>  	 * the secondary pci_bus.
>  	 * We expect only arch-specific PCI host bus controller driver

While you're touching this comment, could you fix the it's/its mistake too?

For native english speakers, the following rule sometimes helps: "its"
is possessive, like "his" and "hers".  You wouldn't write hi's or her's,
so don't write it's.

Non-native english speakers don't tend to get this one wrong.  Probably
because they actually learn english instead of just using it ;-)

Otherwise, Reviewed-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux