Hello!
> I have several cards which report more-or-less garbage in their VPD.
> It can take an extraordinarily long time to read all their VPD and none
> of it is of interest. Instead, if we find an unknown resource type,
> just stop trying to read any more.
This seems wise to do, but we should warn the user. I have applied your
patch with the following on top of it:
commit 169bfd45a4b05df0b6c4a0c17be36d66b6046ab7
Author: Martin Mares <mj@xxxxxx>
Date: Sat Jul 4 15:33:31 2009 +0200
Improve the VPD fix to warn the user that VPD decoding was aborted.
diff --git a/ls-vpd.c b/ls-vpd.c
index 6ded2d8..35c2bfa 100644
--- a/ls-vpd.c
+++ b/ls-vpd.c
@@ -196,7 +196,7 @@ cap_vpd(struct device *d)
break;
default:
- printf("\t\tUnknown %s resource type %02x\n",
+ printf("\t\tUnknown %s resource type %02x, will not decode more.\n",
(tag & 0x80) ? "large" : "small", tag & ~0x80);
return;
}
Have a nice fortnight
--
Martin `MJ' Mares <mj@xxxxxx> http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"I invented the term Object-Oriented, and I can tell you I did not have C++ in mind." -- Alan Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
