On Sun 2009-06-21 00:40:35, H. Peter Anvin wrote: > Pavel Machek wrote: >> On Thu 2009-06-11 13:46:52, H. Peter Anvin wrote: >>> Yinghai Lu wrote: >>>> do we need do that on every cpu? >>>> >>>> looks like we could do that in identify_boot_cpu. >>>> >>> What if the CPUs are heterogenous? It's obviously a suboptimal >>> situation, but it doesn't seem like something we can rely on. >> >> Is it ok if that changes during runtime? What if someone hotplugs >> heterogenous cpu? I'd say basing it on boot cpu seems simplest. > > If someone hotplugs heterogenous CPUs it should do the right thing if > the right thing is possible to do. If you already have resource > assignments that are unfulfillable you're screwed anyway. Ok... and is there enough locking in there so that it is actually ok to change mask during hotplug? (Is it okay because it is single long and all the writers are somehow serialized by hotplug mechanism?) Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html