On Thu, 18 Jun 2009 19:15:59 -0700 Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx> wrote: > Hi Jesse, > > Jesse Barnes wrote: > > On Wed, 13 May 2009 15:43:10 -0600 > > Matthew Wilcox <matthew@xxxxxx> wrote: > > > >> [This is against Jesse's tree which includes my original patch] > >> > >> The previous MSI-X fix (8d181018532dd709ec1f789e374cda92d7b01ce1) > >> had three bugs. First, it didn't move the write that disabled the > >> vector. This led to writing garbage to the MSI-X vector (spotted > >> by Michael Ellerman). It didn't fix the PCI resume case, and it > >> had a race window where the device could generate an interrupt > >> before the MSI-X registers were programmed (leading to a DMA to > >> random addresses). > >> > >> Fortunately, the MSI-X capability has a bit to mask all the > >> vectors. By setting this bit instead of clearing the enable bit, > >> we can ensure the device will not generate spurious interrupts. > >> Since the capability is now enabled, the NIU device will not have > >> a problem with the reads and writes to the MSI-X registers being > >> in the original order in the code. > >> > >> Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> > > > > Applied this one to linux-next. The thread for this had quite a > > bit of discussion though, so if further fixes are needed just send > > me incremental patches on top please. > > I could not find this patch in todays linux-next. > Dropped? Then it's right. In fact there is an updated one that > reposted by Matthew and added my reviewed-by on it. > > It would be best if you could find the Matthew's mail from your mail > box. If it is OK with you, please use this copy (already rebased on > your linux-next). Note that author of this patch is Matthew. I thought maybe I'd lost this by patching a tree on another machine, but it looks like I just missed it altogether when I applied my -next queue last week. It still applies though, just did that now and will push shortly, along with your fix. Thanks, Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
