Re: [PATCH 0/14] ASPM driver cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 17, 2009 at 03:23:43AM +0800, Jesse Barnes wrote:
> On Wed, 13 May 2009 12:10:28 +0900
> Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx> wrote:
> 
> > Hi,
> > 
> > Here is a set of cleanup patches for ASPM drivers. The objective of
> > this set of patches is to make ASPM code easier to read and increase
> > maintainability. This has no functional changes.
> > 
> > The patches are:
> > 
> >   - [PATCH  1/14] PCI ASPM: fix typo in struct pcie_link_state
> >   - [PATCH  2/14] PCI ASPM: cleanup aspm state field in struct
> > pcie_link_state
> >   - [PATCH  3/14] PCI ASPM: cleanup latency field in struct
> > pcie_link_state
> >   - [PATCH  4/14] PCI ASPM: cleanup clkpm state in struct
> > pcie_link_state
> >   - [PATCH  5/14] PCI ASPM: cleanup misc in struct pcie_link_state
> >   - [PATCH  6/14] PCI ASPM: cleanup change input argument of aspm
> > functions
> >   - [PATCH  7/14] PCI ASPM: cleanup initialization
> >   - [PATCH  8/14] PCI ASPM: cleanup __pcie_aspm_check_state_one
> >   - [PATCH  9/14] PCI ASPM: cleanup clkpm checks
> >   - [PATCH 10/14] PCI ASPM: cleanup pcie_aspm_get_cap_device
> >   - [PATCH 11/14] PCI ASPM: cleanup calc_Lx_latency
> >   - [PATCH 12/14] PCI ASPM: remove has_switch field
> >   - [PATCH 13/14] PCI ASPM: cleanup pcie_aspm_sanity_check
> >   - [PATCH 14/14] PCI ASPM: remove get_root_port_link
> 
> Still waiting on Shaohua's ack for these...  Some additional review
> wouldn't hurt either.
Sorry for the late response, was busy these days.
The patches do a lot of renaming, it's hard to say which name is better,
but overall I have no objection.
Acked-by: Shaohua Li <shaohua.li@xxxxxxxxx>

Thanks,
Shaohua
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux