On Mon, Jun 15, 2009 at 01:20:36PM -0600, Alex Chiang wrote: > > Note that "module" is already used in sysfs, so as long as you are > > pointing to the same thing that those other symlinks are, you should be > > fine. You are pointing to /sys/module/NAME, here, right? > > Looks like the common use of "module" is: > > /sys/bus/$bus/drivers/$driver/module -> /sys/module/NAME > > What I was reacting to is that this patch proposes: > > /sys/bus/pci/slots/$slot/module -> /sys/module/NAME > > This scheme is fine as long as only PCI hotplug modules create > those $slot entries. > > But it is limiting, if in the future, we teach the PCI core to > create $slot entries when a low level device driver, say tg3 or > whatever, is loaded. > > In that scenario, it would be more logical if module pointed at > the LLDD's module, not whatever PCI hotplug module happens to > claim that slot It doesn't make any sense for a module like tg3 to claim a slot. Slot drivers claim slots; device drivers claim devices. I think Greg is right, and we should be using 'module' in this case. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
