On Fri, 2009-06-12 at 22:17 +0000, Andrew Patterson wrote: > On Fri, 2009-06-12 at 11:08 +0800, Zhang, Yanmin wrote: > > Anyone could help me test it on powerpc? Or at least a compilation > > to see there is any compiling error/warning. I have no powerpc machine. > > Thanks. > > > > Changelog V4: > > Port the patches to Jesses' linux-next tree (mostly based on > > 2.6.30). > > > > Changelog V3: > > 1) Probe devices under the root port when the bus id of > > the source id is equal to 0; V2 does so when device id is > > equal to 0; > > 2) Add more comments on critical path of finding devices. > > > > Changelog V2: > > Version 2 adds nosourceid, a boot parameter. When > > aerdriver.nosourceid=y, aerdriver doesn't use the source > > id saved by root port. Instead, it searches the device > > tree under the root port to find the reporter. So if hardware > > has errata and root port saves a bad source id, aerdriver > > still could find the reporter. > > There are 2 scenarios under which aerdriver searches the > > device tree under root port: > > 1) nosourceid=n and error source id is equal to 0; > > 2) nosourceid=y. > > > > Based on PCI Express AER specs, a root port might receive multiple > > TLP errors while it could only save a correctable error source id > > and an uncorrectable error source id at the same time. In addition, > > some root port hardware might be unable to provide a correct source > > id, i.e., the source id, or the bus id part of the source id provided > > by root port might be equal to 0. > > > > The patchset implements the support in kernel by searching the device > > tree under the root port. > > > > Patch 1 changes parameter cb of function pci_walk_bus to return a value. > > When cb return non-zero, pci_walk_bus stops more searching on the > > device tree. > > > > Signed-off-by: Zhang Yanmin <yanmin.zhang@xxxxxxxxxxxxxxx> > > > > This one looks fine to me. > > Reviewed-by: Andrew Patterson <andrew.patterson@xxxxxx> Thanks for helping review the patches. Yanmin -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
