On Tuesday 02 June 2009 09:25:16 am Alex Chiang wrote: > A PCI domain cannot change as you descend down subordinate buses, which > makes the 'segment' argument to acpi_pci_irq_add_prt() useless. > > Change the interface to take a struct pci_bus *, from whence we can derive > the bus number and segment. Reducing the number of arguments makes life > simpler for callers. Nice patch. > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c > index 25ddbb6..aa67f72 100644 > --- a/drivers/acpi/pci_root.c > +++ b/drivers/acpi/pci_root.c > @@ -537,8 +537,9 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device) > */ > status = acpi_get_handle(device->handle, METHOD_NAME__PRT, &handle); > if (ACPI_SUCCESS(status)) > - result = acpi_pci_irq_add_prt(device->handle, root->id.segment, > - root->id.bus); > + result = acpi_pci_irq_add_prt(device->handle, > + pci_find_bus(root->id.segment, > + root->id.bus)); I think you can just do this: acpi_pci_irq_add_prt(device->handle, root->bus); Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
