On Mon, 11 May 2009 16:40:17 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote: > From: Michael Ellerman <michael@xxxxxxxxxxxxxx> > Date: Tue, 12 May 2009 00:30:11 +1000 > > > On Sun, 2009-05-10 at 22:36 -0700, David Miller wrote: > >> From: Michael Ellerman <michael@xxxxxxxxxxxxxx> > >> Date: Mon, 11 May 2009 11:21:51 +1000 > >> > >> > So I guess this device is just silently ignoring that write? > >> > >> No, it signals a fault on the PCI bus, which is how we noticed > >> this problem in the first place. > > > > But the patch doesn't change that? It just removes the readl AFAICS: > > I'm on slow satellite internet here out in the ocean, so I wish > the author of this patch would help with your feedback :-/ > > > Or has msix_mask_irq() changed since 413f81eba? > > You could ask GIT, and to answer your question, indeed it has. > > Please don't stall this patch very much, as the bug it is fixing konks > out one of my primary test machines from even booting up. Ok I'll stuff it into my for-linus queue now... Hopefully Matthew can answer the question in the meantime. -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html