* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> @@ -1198,6 +1198,7 @@ int mp_register_gsi(struct device *dev,
> {
> int ioapic;
> int ioapic_pin;
> + struct io_apic_irq_attr io_apic_irq;
please call the variable name 'irq_attr' or so.
> + io_apic_irq.ioapic = ioapic;
> + io_apic_irq.ioapic_pin = ioapic_pin;
> + io_apic_irq.trigger = (triggering == ACPI_EDGE_SENSITIVE ? 0 : 1);
> + io_apic_irq.polarity = (polarity == ACPI_ACTIVE_HIGH ? 0 : 1);
> + io_apic_set_pci_routing(dev, gsi, &io_apic_irq);
I think we've been through this before :-/ Doesnt this:
io_apic_irq.ioapic = ioapic;
io_apic_irq.ioapic_pin = ioapic_pin;
io_apic_irq.trigger = (triggering == ACPI_EDGE_SENSITIVE ? 0 : 1);
io_apic_irq.polarity = (polarity == ACPI_ACTIVE_HIGH ? 0 : 1);
Look nicer?
Also, please do s/triggering/trigger
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
