Hi! > MSI-X table size is 11 bits, not 10. See also PCI_MSIX_FLAGS_QSIZE > in linux/pci_regs.h. Make PCI_MSIX_TABSIZE match that. This looks correct. I'm Cc'ing Roland Dreier, who wrote the original MSI-X dump code back in 2004. Unless Roland objects, I am going to push out a release soon. > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > --- > > It seems that PCI_MSIX_TABSIZE is out of sync with PCI spec > (and with linux/pci_regs.h). Here's an attempt to fix that - > makes sense? > > lib/header.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/header.h b/lib/header.h > index ad8bce6..ec34f44 100644 > --- a/lib/header.h > +++ b/lib/header.h > @@ -862,7 +862,7 @@ > /* MSI-X */ > #define PCI_MSIX_ENABLE 0x8000 > #define PCI_MSIX_MASK 0x4000 > -#define PCI_MSIX_TABSIZE 0x03ff > +#define PCI_MSIX_TABSIZE 0x07ff > #define PCI_MSIX_TABLE 4 > #define PCI_MSIX_PBA 8 > #define PCI_MSIX_BIR 0x7 > -- > 1.6.3.rc3.dirty Have a nice fortnight -- Martin `MJ' Mares <mj@xxxxxx> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth "A semicolon. Another line ends in the dance of camel." -- Kabir Ahuja -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
