On Thu, Apr 16, 2009 at 09:02:16PM -0700, Yinghai Lu wrote:
> Impact: cleanup
>
> it will be assigned late pci_scan_child_bus/pcibios_fixup_bus
Seems to me they're assigned in pci_alloc_child_bus(), not in
pci_scan_child_bus(). Also, pcibios_fixup_bus may adjust them, but it
doesn't assign them. This is all moot as:
> b->number = b->secondary = bus;
> - b->resource[0] = &ioport_resource;
> - b->resource[1] = &iomem_resource;
> +
> + /* don't need assign those for non root buses */
> + if (!parent) {
> + b->resource[0] = &ioport_resource;
> + b->resource[1] = &iomem_resource;
> + }
>
parent != NULL does *NOT* mean non-root bus. Get your head out of
x86 and realise we have architectures which have pci root busses which
have parents.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
