On Wed, Mar 11, 2009 at 03:25:42PM +0800, Yu Zhao wrote:
> +config PCI_IOV
> + bool "PCI IOV support"
> + depends on PCI
> + help
> + PCI-SIG I/O Virtualization (IOV) Specifications support.
> + Single Root IOV: allows the creation of virtual PCI devices
> + that share the physical resources from a real device.
> +
> + When in doubt, say N.
It's certainly shorter than my text, which is nice. But I think it
still has too much spec-ese and not enough explanation. How about:
help
I/O Virtualization is a PCI feature supported by some devices
which allows them to create virtual devices which share their
physical resources.
If unsure, say N.
> + list_for_each_entry(pdev, &dev->bus->devices, bus_list)
> + if (pdev->is_physfn)
> + break;
> + if (list_empty(&dev->bus->devices) || !pdev->is_physfn)
> + pdev = NULL;
This is still wrong. If the 'break' condition is not hit, pdev is
pointing to garbage, not to the last pci_dev in the list.
> @@ -270,6 +278,7 @@ struct pci_dev {
> struct list_head msi_list;
> #endif
> struct pci_vpd *vpd;
> + struct pci_sriov *sriov; /* SR-IOV capability related */
Should be ifdeffed?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
