Re: [PATCH 1/2] pci_hotplug: add an uevent framework to pci_hotplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg KH wrote:
On Thu, Mar 19, 2009 at 09:29:19AM +0900, Kenji Kaneshige wrote:
Greg KH wrote:
On Wed, Mar 18, 2009 at 06:07:35PM +0900, Taku Izumi wrote:
Kenji-san, Greg

Thank you for reviewing.
I'll consider about what you pointed out for a while...


How about adding new file under sys/bus/pci/<slot name> directory
to indicate which php driver manages the slot, instead of adding
PCIHP_DRV_NAME environment variable. I had some experiences that
it was difficult to know the slot was manged by what php driver
in debugging. So the new file will be useful for debugging too.
Is what you say this?
driver "owners" are shown in sysfs as symlinks today, please don't
create a different way of showing them that is special for just pci
devices, that's not nice to users.

What about controller name instead?

As a symlink, that might make more sense, but I would like to see how it
looks before agreeing to it :)


I misunderstood your original comment. I thought you meant
we should not create any files (including symlinks) related
to driver under the slot directory.

A symlink to the hotplug driver sounds good to me, though I
have not examined if we can implement it easily.

Thanks,
Kenji Kaneshige


thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux