Re: [PATCH] PCIe portdrv: eliminate double kfree in remove path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 09 March 2009, Alex Chiang wrote:
> Commit 55633af3 (PCIe portdrv: Use driver data to simplify code)
> added a kfree of the driver private data in pcie_port_device_remove
> but forgot to remove the old kfree from pcie_portdrv_remove.

Ah, sorry for that, it resulted in quite a lot of debugging work for you. :-(

> Signed-off-by: Alex Chiang <achiang@xxxxxx>

Acked-by; Rafael J. Wysocki <rjw@xxxxxxx>

> ---
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index a6fee6c..f2368b1 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -93,7 +93,6 @@ static int __devinit pcie_portdrv_probe (struct pci_dev *dev,
>  static void pcie_portdrv_remove (struct pci_dev *dev)
>  {
>  	pcie_port_device_remove(dev);
> -	kfree(pci_get_drvdata(dev));
>  }
>  
>  static int error_detected_iter(struct device *device, void *data)
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux