Ingo Molnar wrote: > * Daniel Yeisley <dan.yeisley@xxxxxxxxxx> wrote: > >> On Fri, 2009-03-06 at 19:45 +0100, Ingo Molnar wrote: >>> * Daniel Yeisley <dan.yeisley@xxxxxxxxxx> wrote: >>> >>>> Commit-ID: affd49d36e2e2df4cbb3e07a57db901c23823b6a >>>> Gitweb: http://git.kernel.org/tip/affd49d36e2e2df4cbb3e07a57db901c23823b6a >>>> Author: "Daniel Yeisley" <dan.yeisley@xxxxxxxxxx> >>>> AuthorDate: Fri, 6 Mar 2009 10:11:49 -0500 >>>> Commit: Ingo Molnar <mingo@xxxxxxx> >>>> CommitDate: Fri, 6 Mar 2009 19:32:44 +0100 >>>> >>>> x86: MSI: check for BIOS assigned addresses >>>> >>>> Impact: fix ACPI hotplug on certain systems >>> Note, this commit means that i moved the commit over from >>> tip:x86/urgent into tip:x86/apic - i.e. with a 2.6.30 merge >>> date. When exactly was this regression introduced? I think this >>> code never really accepted the MSI settings from the firmware, >>> so changing that behavior might affect a lot of systems. >>> >>> So i'm uneasy about applying this fix this late in the .29 >>> cycle, but marked it for -stable backport so it could hit >>> 2.6.29.1 if it stays problem-free. >>> >>> Ingo >> I initially noticed the problem on a 2.6.18 kernel. ACPI >> hotplugging didn't work unless I booted with pci=nomsi. I >> don't have a problem with waiting until 2.6.30 to make sure it >> is thoroughly tested. > > Okay - so it's an ancient bug. The current track should thus be > fine. > please drop this patch. it seems it break msi-x. at least igbe with msi-x does not work anymore. YH -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html